Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Check for missing order metadata #320

Merged
merged 1 commit into from
May 27, 2022
Merged

Fix: Check for missing order metadata #320

merged 1 commit into from
May 27, 2022

Conversation

sethobey
Copy link
Contributor

Context

#319

Description

As of PHP 8.1, should check for encoded metadata before attempting to decode.

Versions

  • Magento 2.4
  • Magento 2.3
  • Magento Open Source (CE)
  • Magento Commerce (EE)
  • Magento B2B
  • Magento Cloud
  • PHP 7.x
  • PHP 8.1

@sethobey sethobey merged commit b460435 into develop May 27, 2022
@sethobey sethobey deleted the fix-json-encode-null-error branch May 27, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dallendalton dallendalton dallendalton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sethobey @dallendalton @sethobey-stripe