Adding editorial changes on top of PR that introduces new terminology. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major changes are: * Replacing "associated with" with a more descriptive phrase whenever possible. * Using the terms '"m=" line' and '"m=" section" consistently.
cdh4u
reviewed
Feb 8, 2017
| </t> | ||
| <section title="Connection Data (c=)" anchor="sec-sdp-cons-c" toc="default"> | ||
| <t> | ||
| The "c=" line nettype value <xref format="default" pageno="false" | ||
| target="RFC4566"/> associated with a bundled "m=" line MUST be 'IN'. | ||
| target="RFC4566"/> in a bundled "m=" section MUST be 'IN'. |
There was a problem hiding this comment.
Normally the c= line is now in an "m=" section (assuming "m=" section refers to the m- line and each associated attribute).
cdh4u
reviewed
Feb 8, 2017
| The usage of the 'bundle-only' attribute is only defined for a bundled "m=" line with | ||
| a zero port value, within an offer. Other usage is unspecified. | ||
| The usage of the 'bundle-only' attribute is only defined for a bundled "m=" section with | ||
| a zero port value on its "m=" line, within an offer. Other usage is unspecified. |
There was a problem hiding this comment.
Would we need to say "on its "m=" line", or could we simply say '"m=" section with a zero port value'?
cdh4u
reviewed
Feb 8, 2017
| @@ -1261,7 +1261,7 @@ SDP Answer | |||
| which specifies semantics for the usage of a non-zero port value, is | |||
| used. If the stream is marked with port zero in the answer, the answer | |||
| MAY omit all attributes present previously, and MAY list | |||
There was a problem hiding this comment.
Is there a reason why you say "present" here, while elsewhere you say "contain"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes are:
possible.