Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeneralDecoding.swift performance regression #43

Closed
tayloraswift opened this issue Aug 1, 2022 · 1 comment
Closed

GeneralDecoding.swift performance regression #43

tayloraswift opened this issue Aug 1, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@tayloraswift
Copy link
Owner

benchmarks CI caught a major performance regression with commit 59d34c5f8c337b068d07ad5b0e4caa2fd0b8176e

before:

 [15/16] Linking benchmark
Build complete! (50.69s)
swift-json: decoded 38295 messages
foundation: decoded 38295 messages
swift-json decoding time: 0.497709959 seconds
foundation decoding time: 4.90599839 seconds

after:

[15/16] Linking benchmark
Build complete! (45.21s)
swift-json: decoded 38295 messages
foundation: decoded 38295 messages
swift-json decoding time: 3.21054002 seconds
foundation decoding time: 4.539217732 seconds
@tayloraswift tayloraswift added the bug Something isn't working label Aug 1, 2022
@tayloraswift
Copy link
Owner Author

link #33

@tayloraswift tayloraswift mentioned this issue Aug 1, 2022
Merged
tayloraswift added a commit that referenced this issue Aug 1, 2022
@tayloraswift
fix benchmark regression (#43) (#44)
578137c 
* reproduce benchmark regression

* nest Root rule in another enum

* move doccomment back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tayloraswift