fix benchmark regression (#43) #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tayloraswift
commented
Aug 1, 2022
Sources/JSON/JSON.Rule.swift
Outdated
| @@ -45,7 +45,7 @@ extension JSON | |||
| /// even when applied to third-party collection types, like | |||
| /// ``/swift-nio/NIOCore/ByteBufferView``. | |||
| public | |||
| enum Rule<Location> | |||
| enum Rule<Location>:ParsingRule | |||
There was a problem hiding this comment.
code with JSON.Rule<Location> implementing the root ParsingRule:
Build complete! (37.48s)
swift-json: decoded 38295 messages
foundation: decoded 38295 messages
swift-json decoding time: 2.875409557 seconds
foundation decoding time: 3.795551295 seconds
tayloraswift
commented
Aug 1, 2022
| // enum Root:ParsingRule | ||
| // { | ||
| public | ||
| enum Root:ParsingRule |
There was a problem hiding this comment.
code with JSON.Rule<Location>.Root implementing ParsingRule:
[15/16] Linking benchmark
Build complete! (45.71s)
swift-json: decoded 38295 messages
foundation: decoded 38295 messages
swift-json decoding time: 0.482016238 seconds
foundation decoding time: 4.450682692 seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request is meant to reproduce the regression in #43, and provide a patch fix