Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type define is not valid #73

Closed
hustcc opened this issue Jan 14, 2020 · 4 comments
Closed

type define is not valid #73

hustcc opened this issue Jan 14, 2020 · 4 comments

Comments

@hustcc
Copy link

hustcc commented Jan 14, 2020

current is:

export function format(dateObj: Date | number, mask: string, i18nSettings?: i18nSettings): string;
export function parse(dateStr: string, format: string, i18nSettings?: i18nSettings): Date | null;

should be:

type Fecha = {
  format: (dateObj: Date | number, mask: string, i18nSettings?: i18nSettings): string;
  parse: (dateStr: string, format: string, i18nSettings?: i18nSettings): Date | null;
}

export default Fecha;
@taylorhakes
Copy link
Owner

This is fixed in the newest version 4.0.0. Thanks for the report

@hustcc
Copy link
Author

hustcc commented Jan 14, 2020

when 4.0.0 release?

@hustcc
Copy link
Author

hustcc commented Jan 16, 2020

I saw the code is rewrite with typescript, When will the new version be released?

@taylorhakes
Copy link
Owner

taylorhakes commented Jan 16, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants