-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New element: SetTCPChecksumIP6 - Calculates TCP/IPv6 checksum and sets the TCP header field. #332
Conversation
… the checksum header field.
I do see that a "CodeQL" build step is failing on the PR (but all builds are successful), but this one does not seem related to my code, it says:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! Could you just set the copyright correctly?
elements/tcpudp/settcpchecksumip6.cc
Outdated
@@ -0,0 +1,71 @@ | |||
/* | |||
* settcpchecksumip6.{cc,hh} -- sets the TCP header checksum for IPv6 packets | |||
* Robert Morris |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add your name and copyright institution? Maybe add "based on settcpchecksum.{cc,hh}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, of course. I didn't want to claim too much credit, but the way you suggest it is a good way, referencing the others. Pushed!
Yes the codeql seemed to be a false positive, I'll check after it re-ran. |
Copyright was changed as asked (thanks!), now I think only CodeQL is acting up again. |
Elment needs ip6 to be enabled
I found the problem, codeql does not compile with --enable-ip6 and therefore the element is missing a symbol. It's actually legit Should be fixed with the last commit. I'll merge when it passes. Thanks! |
Bad luck... Github has an issue with name resolution right now and cannot resolve fast.dpdk.org... Will re-launch the CI in a bit. |
Thanks for the quick merge, Tom! And thank you for doing fastclick! |
The existing
SetTCPChecksum
element only supports TCP over IPv4. This is a new element that does the same for TCP over IPv6.The new element's naming convention follows
FastUDPSource
andFastUDPSourceIP6
, and is also the reason I've put this intcpudp/
instead ofip6/
.The code is based mostly on the original
SetTCPChecksum
and the wayFastUDPSourceIP6
calculates checksum for its packets.