Escape HTML #16
Merged
Escape HTML #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes a DOM XSS vulnerability. The truncate method decodes HTML-encoded entities. The decoded data is then written back to the DOM without HTML-encoding. This may introduce new XSS vulnerabilities in applications following application security best practices. Test case using jQuery 1.8.3 and jQuery-truncate (Jun 03, 2013 release) Test case using jQuery 1.8.3 and jQuery-truncate (dfournier's fix_escape_html branch) Best regards, |
|
Thanks to both of you! @DFournier for fixing this and @bugch3ck for bringing it up again after the pull request slipped my attention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent injection, the content is inserted with
jquery.textinstead ofjquery.html.