Add new option to cache style and $truncateWorker when working with multiple elements. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! |
tbasse
added a commit
that referenced
this pull request
May 21, 2014
Add new option to cache style and $truncateWorker when working with multiple elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a bunch of elements with the same style and you run truncate it can be very slow (was seeing up to 2 second browser freezes with 50 elements). Caching the style and $truncateWorker from outside of the loop can reduce this to 10ms (element creation and is very slow in jQuery). Obviously only useful if your elements share the same style.