Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make increaseTime do its job #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KennyStier
Copy link

Fixes #1

@KennyStier
Copy link
Author

KennyStier commented Jan 19, 2020

Well...I thought I fixed it. Found out this breaks timeDirection = 'down' 😅

I guess I got a little ahead of myself

@tbleckert
Copy link
Owner

First of all, thanks for bringing this back to life! Secondly, good finding, didn't think of it at the time.

Yeah, the naming of increaseTime and decreaseTime is a bit confusing since they work differently depending on the direction.

The best solution is probably to keep your fix, but also change the startTime method and update the interval to use either increase or decrease based on the timeDirection setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If timeDirection = 'down', increaseTime does not work
2 participants