Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use production mode on Lucky / Raze / Kemal #139

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Use production mode on Lucky / Raze / Kemal #139

merged 1 commit into from
Feb 27, 2018

Conversation

waghanza
Copy link
Collaborator

Hi @tbrand,

To specify production mode usage, we SHOULD export environment variable.

I have set those, on make.

I don't know :

  • how to set for neph
  • if router.cr use such a feature

Regards,

This fix #138

tbrand
tbrand approved these changes Feb 27, 2018
View reviewed changes
Copy link
Collaborator

@tbrand tbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If you could fix neph.yaml, that's ideal. 💯

@tbrand tbrand merged commit 7088f3b into the-benchmarker:master Feb 27, 2018
@waghanza waghanza deleted the crystal_on_production branch February 27, 2018 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrand tbrand tbrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crystal framework are running on development
2 participants
@waghanza @tbrand