Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crystal framework are running on development #138

Closed
waghanza opened this issue Feb 26, 2018 · 2 comments · Fixed by #139
Closed

Crystal framework are running on development #138

waghanza opened this issue Feb 26, 2018 · 2 comments · Fixed by #139

Comments

@waghanza
Copy link
Collaborator

Hi,

I do not know about other frameworks, but :

⚠️ Mode is choosed with environment var, I don't know how to set them via neph

@tbrand I do not know if there is a mode for route_cr

@waghanza
Copy link
Collaborator Author

waghanza commented Feb 27, 2018

@tbrand It appears the environment is not used by kemal, raze, ...

in fact make / neph could be aware of CRYSTAL_ENV ... but those vars are not exported to processes behind (e.g : symlinks in bin/).

For me there is 3 solutions :

  • Hard-code the environment in each framework code
  • Use benchmarker to export variable to running childs (e.g : each frameworks)
  • Use docker for isolation (proper environment for each frameworks)

@waghanza waghanza reopened this Feb 27, 2018
@waghanza
Copy link
Collaborator Author

@tbrand it appear that frameworks are still running on development.

I've fixed this on #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant