WIP: 2.0.0 #270
Merged
WIP: 2.0.0 #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
tbranyen
commented
Aug 26, 2015
tbranyen
commented
- Removed Bower in favor of NPM
- Removed grunt-bbb-server for grunt-connect
- Updated the README, LICENSE, and other meta-files.
- Added the watch task and NPM scripts.
- Converted to ES6 and added Browserify, Babelify, and Combynify.
- Added in some application structure and component class.
tbranyen
force-pushed
the
2.0.0
branch
2 times, most recently
from
1e47d2b
to
f23a837
Compare
|
|
||
| branches: | ||
| only: | ||
| - master | ||
|
|
||
| before_script: | ||
| - npm install -gq grunt-cli bower coveralls | ||
| - bower install | ||
| - npm install -gq coveralls |
There was a problem hiding this comment.
We usually don't need to install cli tool globally as npm include the local package binaries in the PATH of npm scripts.
There was a problem hiding this comment.
Yup, exactly why I removed grunt-cli. I removed coveralls as a dependency, so its installed globally here. But to your point, since NPM scripts sources them, I should be able to get away without global here.
Closed
tbranyen
force-pushed
the
2.0.0
branch
7 times, most recently
from
14246be
to
8ec6e6b
Compare
- Removed Bower in favor of NPM - Removed grunt-bbb-server for grunt-connect - Updated the README, LICENSE, and other meta-files. - Added the watch task and NPM scripts.
This kills the AMD and adds in the ES6.
Being more opinionated with Mocha and assert. Converted tests to ES6 as well.
The styles Grunt plugin was really cool, but I don't have time to maintain it. Since it never left beta, I'm going to remove it in favor of the Grunt contrib team's cssmin. If you want to use a preprocessor, it's trivial to add. I've added a bunch of application files to demonstrate how to integrate the router, components, etc. into your application.
|
Gonna merge as-is, I'll have more time to update the rest of this later. |
| @@ -1,3 +0,0 @@ | |||
| { | |||
| "directory": "bower_components" | |||
| } | |||
| super(); | ||
|
|
||
| // Not sure why super doesn't call the correct constructor :-/ | ||
| LayoutManager.prototype.constructor.apply(this, arguments); |
There was a problem hiding this comment.
what constructor is it calling instead? 😮
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.