Rename process to internalProcess #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbranyen
commented
Apr 14, 2022
|
Another day, another Webpack issue. But, I think your Rollup config is already explicitly trying to replace
Make sure to fix up those Rollup replacements too! |
This fixes GH-268. Webpack has issues with the process variable and by renaming the internal usage we can ensure that it points to our representation and not the external one.
tbranyen
force-pushed
the
rename-internal-process
branch
from
a114902
to
f160c2c
Compare
|
Good catch, thanks for the review! |
tbranyen
commented
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes GH-268. Webpack has issues with the process variable and by
renaming the internal usage we can ensure that it points to our
representation and not the external one.