Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tox ci #10

Merged
merged 19 commits into from
Jan 28, 2024
Merged

Fix tox ci #10

merged 19 commits into from
Jan 28, 2024

Conversation

tbrlpld
Copy link
Owner

@tbrlpld tbrlpld commented Jan 25, 2024

This PR fixes the tox configuration in CI.

The gh-actions:env section was not needed. It actually led to not all environment combinations being run and it also meant that the dependency installation did not happen in the expected environments.

See: ymyzk/tox-gh-actions#193

One symptom of the above was the we never actually tested with Django 3.2 in CI (which was noticed because it led to errors when running tox locally, where the environments were working just fine). Now we are properly testing Django 3.2 on CI as well.

Another symptom of the above was that we needed to redefine coverage in the tox.ini dependencies although it is already listed in the testing dependencies in pyproject.toml.

The redefinition of coverage was also solved (before the above complete solution to the environment issue) previously by switching from skipsdist, usedevelop and a custom install_command to the more modern tox config options extras = testing and package = editable.

Also bumps CI versions to not use deprecated Node version 16 anymore.

@tbrlpld tbrlpld changed the base branch from main to improve-docs January 25, 2024 03:43
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe8a7ec) 99.52% compared to head (41fa424) 100.00%.
Report is 20 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #10      +/-   ##
===========================================
+ Coverage   99.52%   100.00%   +0.47%     
===========================================
  Files          12        12              
  Lines         212       212              
===========================================
+ Hits          211       212       +1     
+ Misses          1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tbrlpld tbrlpld marked this pull request as ready for review January 25, 2024 04:33
@tbrlpld tbrlpld marked this pull request as draft January 25, 2024 04:33
@tbrlpld tbrlpld self-assigned this Jan 25, 2024
@tbrlpld tbrlpld mentioned this pull request Jan 26, 2024
@tbrlpld tbrlpld marked this pull request as ready for review January 26, 2024 03:56
@tbrlpld tbrlpld force-pushed the improve-docs branch 2 times, most recently from d563270 to 3ebda1b Compare January 27, 2024 17:15
@tbrlpld tbrlpld changed the base branch from improve-docs to main January 27, 2024 17:40
@tbrlpld tbrlpld disabled auto-merge January 27, 2024 17:59
@tbrlpld tbrlpld closed this Jan 28, 2024
auto-merge was automatically disabled January 28, 2024 14:02

Pull request was closed

@tbrlpld tbrlpld reopened this Jan 28, 2024
@tbrlpld tbrlpld closed this Jan 28, 2024
@tbrlpld tbrlpld reopened this Jan 28, 2024
@tbrlpld tbrlpld closed this Jan 28, 2024
@tbrlpld tbrlpld reopened this Jan 28, 2024
@tbrlpld tbrlpld merged commit f04b52d into main Jan 28, 2024
20 of 24 checks passed
@tbrlpld tbrlpld deleted the fix-tox-ci branch January 28, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant