Remove @@species lookup from Promise.all() and Promise.race()

[claudepache]

See https://esdiscuss.org/topic/resolve-reject-on-promise-subclasses-and-species

[zloirock]

@@species from Promise.resolve and Promise.reject was removed after this issue. Will be strange also remove it from Promise.all and Promise.race, but leave it in Promise#then / Promise#catch.

[zloirock]

@@species from Promise.resolve and Promise.reject was removed after this issue. Will be strange also remove it from Promise.all and Promise.race, but leave it in Promise#then / Promise#catch.

[claudepache]

@zloirock It would be consistent with, e.g., Array.from, etc. (static method, explicit constructor, no @@species lookup) vs. Array#slice, etc. (instance method, implicit constructor, @@species lookup).

[claudepache]

@zloirock It would be consistent with, e.g., Array.from, etc. (static method, explicit constructor, no @@species lookup) vs. Array#slice, etc. (instance method, implicit constructor, @@species lookup).

[zloirock]

@claudepache it will be consistent, but only for me this approach seems strange? For prototype methods - new this.constructor[@@species], for statics - instead of new this[@@species] just new this. In this case, it would be logical to store @@species on prototype.

[zloirock]

@claudepache it will be consistent, but only for me this approach seems strange? For prototype methods - new this.constructor[@@species], for statics - instead of new this[@@species] just new this. In this case, it would be logical to store @@species on prototype.

[bterlson]

We are going to remove @@species from promise.all and promise.race. PR's accepted!

[bterlson]

We are going to remove @@species from promise.all and promise.race. PR's accepted!

[cscott]

Um, we need an exact spec. There are two different uses of species in promise.all/race, as I described in the thread above. I made a proposal for how the two uses should be resolved; are you adopting my wording?

[cscott]

Um, we need an exact spec. There are two different uses of species in promise.all/race, as I described in the thread above. I made a proposal for how the two uses should be resolved; are you adopting my wording?

[cscott]

In particular, the wording in https://esdiscuss.org/topic/resolve-reject-on-promise-subclasses-and-species#content-5

[cscott]

In particular, the wording in https://esdiscuss.org/topic/resolve-reject-on-promise-subclasses-and-species#content-5