Restore early SyntaxError for strict mode assignment to eval/arguments #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Mar 6, 2018
spec.html
Outdated
| @@ -14451,13 +14457,19 @@ <h1>Static Semantics: Early Errors</h1> | |||
| It is a Syntax Error if |LeftHandSideExpression| is either an |ObjectLiteral| or an |ArrayLiteral| and |LeftHandSideExpression| is not covering an |AssignmentPattern|. | |||
| </li> | |||
| <li> | |||
| It is an early Reference Error if |LeftHandSideExpression| is neither an |ObjectLiteral| nor an |ArrayLiteral| and IsValidSimpleAssignmentTarget of |LeftHandSideExpression| is *false*. | |||
| It is an early Reference Error if |LeftHandSideExpression| is neither an |ObjectLiteral| nor an |ArrayLiteral| and IsValidSimpleAssignmentTarget of |LeftHandSideExpression| is ~invalid~. | |||
There was a problem hiding this comment.
It seems strange to have something named as a predicate (IsValidSimpleAssignmentTarget) not be a boolean. Should this be renamed to something else?
There was a problem hiding this comment.
SimpleAssignmentTarget, AssignmentTarget{Type,Hint} should do the trick or whatever @anba decides works for me as well.
For anything else, this PR LGTM. +1
littledan
added
normative change
|
Thanks for following up on this old issue and helping us get aligned with web reality. LGTM, seems like an accurate fix of the linked bug. Test262 tests would be great. |
Already covered by:
|
littledan
added
has test262 tests
and removed
needs test262 tests
|
OK, it seems like this was an accidental change vs previous versions, corresponds to implementation consensus and tests, and simply restores things from before the typo. I think we should consider this patch ready to land. |
ljharb
requested changes
Jul 19, 2018
spec.html
Outdated
| @@ -13064,7 +13064,10 @@ <h1>Static Semantics: Early Errors</h1> | |||
| </emu-grammar> | |||
| <ul> | |||
| <li> | |||
| It is an early Reference Error if IsValidSimpleAssignmentTarget of |LeftHandSideExpression| is *false*. | |||
| It is an early Reference Error if IsValidSimpleAssignmentTarget of |LeftHandSideExpression| is ~invalid~. | |||
There was a problem hiding this comment.
This still needs to be renamed to not have an “is” prefix` on an enum
There was a problem hiding this comment.
in the editor's call, we decided to rename this to "AssignmentTargetType". I'll take care of this as part of the rebase and merge.
bterlson
approved these changes
Aug 1, 2018
bmeck
approved these changes
Aug 1, 2018
ljharb
force-pushed
the
invalid-strict-mode-assign
branch
from
2272bfb
to
02f414c
Compare
ljharb
approved these changes
Aug 1, 2018
adrianheine
reviewed
Jan 20, 2019
| It is an early Reference Error if AssignmentTargetType of |UnaryExpression| is ~invalid~. | ||
| </li> | ||
| <li> | ||
| It is an early Syntax Error if AssignmentTargetType of |LeftHandSideExpression| is ~strict~. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.ecmascript.org/show_bug.cgi?id=4375
Closes #1267.