Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames Atomics.wake => Atomics.notify #1220

Merged
merged 1 commit into from Aug 1, 2018

Conversation

Projects
None yet
6 participants
@jridgewell

This comment has been minimized.

Copy link
Member

jridgewell commented Jun 8, 2018

@ljharb: Didn't we achieve consensus in May?

I can't check, the docs are now restricted access and the notes haven't been published...

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Jun 8, 2018

I thought we did, but i wasn't sure, due to the wording in the OP. Let's get those notes out ASAP so we can confirm.

@rwaldron

This comment has been minimized.

Copy link
Contributor Author

rwaldron commented Jun 8, 2018

I'm still waiting on a summary, but the notes are published now: https://tc39.github.io/tc39-notes/2018-05_toc.html. The checkbox items above are copied verbatim from the notes: https://tc39.github.io/tc39-notes/2018-05_may-22.html#conclusionresolution-rename-atomicswake

Also relevant: nodejs/node#21219

@rwaldron rwaldron force-pushed the atomics-notify branch from e62687a to 0ccd8b5 Jun 19, 2018

@rwaldron

This comment has been minimized.

Copy link
Contributor Author

rwaldron commented Jun 22, 2018

Turns out those occurrences of https://github.com/EpicGames/UnrealEngine that I found are public copies of a private repo. In order to get access, I will need to:

  • be an Unreal Engine subscriber.
  • have a GitHub account.
  • have associated your GitHub account with your Unreal Engine account as described on the UE4 on GitHub page.

(According to https://docs.unrealengine.com/en-us/GettingStarted/DownloadingUnrealEngine)

@littledan

This comment has been minimized.

Copy link
Member

littledan commented Jun 24, 2018

The outreach effort seems really good, and I'm glad you're doing it, but I don't think we need to wait on landing this change until the outreach effort is complete. I bet unshipping and hopefully soon re-shipping SharedArrayBuffer provides enough chaos that this will not be the same kind of "break the web" event as we've seen with other TC39 changes. At the same time, it's important that this patch does land soon, if we want to do it, so as to avoid potential future web compat issues.

cc @binji

targos added a commit to nodejs/node that referenced this pull request Jul 3, 2018

2018-07-04, Version 10.6.0 (Current)
Notable changes:

* build:
  * Node.js should now be about 60% faster to startup than the previous version,
    thanks to the use V8's code cache feature for core modules. [#21405](#21405)
* dns:
  * An experimental promisified version of the dns module is now available. Give
    it a try with `require('dns').promises`. [#21264](#21264)
* fs:
  * `fs.lchown` has been undeprecated now that libuv supports it. [#21498](#21498)
* lib:
  * `Atomics.wake` is being renamed to `Atomics.notify` in the ECMAScript
    specification ([reference](tc39/ecma262#1220)).
    Since Node.js now has experimental support for worker threads, we are being
    proactive and added a `notify` alias, while emitting a warning if
    `wake` is used. [#21413](#21413) [#21518](#21518)
* n-api:
  * Add API for asynchronous functions. [#17887](#17887)
* util:
  * `util.inspect` is now able to return a result instead of throwing when the
    maximum call stack size is exceeded during inspection. [#20725](#20725)
* vm:
  * Add `script.createCachedData()`. This API replaces the `produceCachedData`
    option of the `Script` constructor that is now deprecated. [#20300](#20300)
* worker:
  * Support for relative paths has been added to the `Worker` constructor. Paths
    are interpreted relative to the current working directory. [#21407](#21407)

@targos targos referenced this pull request Jul 3, 2018

Merged

v10.6.0 proposal #21629

targos added a commit to nodejs/node that referenced this pull request Jul 3, 2018

2018-07-04, Version 10.6.0 (Current)
Notable changes:

* build:
  * Node.js should now be about 60% faster to startup than the previous version,
    thanks to the use V8's code cache feature for core modules. [#21405](#21405)
* dns:
  * An experimental promisified version of the dns module is now available. Give
    it a try with `require('dns').promises`. [#21264](#21264)
* fs:
  * `fs.lchown` has been undeprecated now that libuv supports it. [#21498](#21498)
* lib:
  * `Atomics.wake` is being renamed to `Atomics.notify` in the ECMAScript
    specification ([reference](tc39/ecma262#1220)).
    Since Node.js now has experimental support for worker threads, we are being
    proactive and added a `notify` alias, while emitting a warning if
    `wake` is used. [#21413](#21413) [#21518](#21518)
* n-api:
  * Add API for asynchronous functions. [#17887](#17887)
* util:
  * `util.inspect` is now able to return a result instead of throwing when the
    maximum call stack size is exceeded during inspection. [#20725](#20725)
* vm:
  * Add `script.createCachedData()`. This API replaces the `produceCachedData`
    option of the `Script` constructor that is now deprecated. [#20300](#20300)
* worker:
  * Support for relative paths has been added to the `Worker` constructor. Paths
    are interpreted relative to the current working directory. [#21407](#21407)

PR-URL: #21629

targos added a commit to nodejs/node that referenced this pull request Jul 4, 2018

2018-07-04, Version 10.6.0 (Current)
Notable changes:

* dns:
  * An experimental promisified version of the dns module is now available. Give
    it a try with `require('dns').promises`. [#21264](#21264)
* fs:
  * `fs.lchown` has been undeprecated now that libuv supports it. [#21498](#21498)
* lib:
  * `Atomics.wake` is being renamed to `Atomics.notify` in the ECMAScript
    specification ([reference](tc39/ecma262#1220)).
    Since Node.js now has experimental support for worker threads, we are being
    proactive and added a `notify` alias, while emitting a warning if
    `wake` is used. [#21413](#21413) [#21518](#21518)
* n-api:
  * Add API for asynchronous functions. [#17887](#17887)
* util:
  * `util.inspect` is now able to return a result instead of throwing when the
    maximum call stack size is exceeded during inspection. [#20725](#20725)
* vm:
  * Add `script.createCachedData()`. This API replaces the `produceCachedData`
    option of the `Script` constructor that is now deprecated. [#20300](#20300)
* worker:
  * Support for relative paths has been added to the `Worker` constructor. Paths
    are interpreted relative to the current working directory. [#21407](#21407)

PR-URL: #21629

targos added a commit to nodejs/node that referenced this pull request Jul 4, 2018

2018-07-04, Version 10.6.0 (Current)
Notable changes:

* dns:
  * An experimental promisified version of the dns module is now available. Give
    it a try with `require('dns').promises`. [#21264](#21264)
* fs:
  * `fs.lchown` has been undeprecated now that libuv supports it. [#21498](#21498)
* lib:
  * `Atomics.wake` is being renamed to `Atomics.notify` in the ECMAScript
    specification ([reference](tc39/ecma262#1220)).
    Since Node.js now has experimental support for worker threads, we are being
    proactive and added a `notify` alias, while emitting a warning if
    `wake` is used. [#21413](#21413) [#21518](#21518)
* n-api:
  * Add API for asynchronous functions. [#17887](#17887)
* util:
  * `util.inspect` is now able to return a result instead of throwing when the
    maximum call stack size is exceeded during inspection. [#20725](#20725)
* vm:
  * Add `script.createCachedData()`. This API replaces the `produceCachedData`
    option of the `Script` constructor that is now deprecated. [#20300](#20300)
* worker:
  * Support for relative paths has been added to the `Worker` constructor. Paths
    are interpreted relative to the current working directory. [#21407](#21407)

PR-URL: #21629

@ljharb ljharb referenced this pull request Jul 24, 2018

Open

July 2018 #46

@ljharb ljharb added the needs tests label Jul 24, 2018

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Jul 24, 2018

Tests are here: tc39/test262#1614 will update the label once merged.

@rwaldron

This comment has been minimized.

Copy link
Contributor Author

rwaldron commented Jul 24, 2018

@ljharb merged!

@ljharb

ljharb approved these changes Jul 24, 2018

@ljharb ljharb requested review from bterlson and bmeck Jul 24, 2018

@bmeck

bmeck approved these changes Jul 24, 2018

@littledan

This comment has been minimized.

Copy link
Member

littledan commented Jul 27, 2018

We reaffirmed consensus on this change in the July 2018 TC39 meeting. Is this patch ready to merge, then?

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Jul 27, 2018

Yes - see
#1220 (comment) - and we'll review it in our next editors' call.

@ljharb ljharb assigned ljharb and unassigned bterlson Aug 1, 2018

@ljharb ljharb force-pushed the atomics-notify branch from 0ccd8b5 to fb23016 Aug 1, 2018

@ljharb ljharb merged commit fb23016 into master Aug 1, 2018

1 check was pending

continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@ljharb ljharb deleted the atomics-notify branch Aug 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.