Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: add missing Annex E entries #1698

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Editorial: add missing Annex E entries #1698

merged 2 commits into from
Oct 18, 2019

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Sep 16, 2019 •
edited
Loading

Post-ES2015, Annex E hasn't been kept up to date, but there have been breaking changes:

This PR adds those missing entries. Suggestions on how to phrase the prose are welcome; and if I'm missing any changes, please let me know.

Entries remain sorted by section number/position in the spec, not by edition year.

@ljharb
Copy link
Member Author

ljharb commented Sep 16, 2019 •
edited
Loading

cc @allenwb @bterlson @littledan @syg @MayaLekova @rwaldron @devsnek @mathiasbynens @getify @WebReflection @bakkot

getify
getify reviewed Sep 16, 2019
View reviewed changes
spec.html Outdated Show resolved Hide resolved
getify
getify reviewed Sep 16, 2019
View reviewed changes
spec.html Outdated Show resolved Hide resolved
@ljharb ljharb mentioned this pull request Sep 16, 2019
Open
@syg
Copy link
Contributor

syg commented Sep 17, 2019

The Atomics.wake rename lgtm.

mathiasbynens
mathiasbynens reviewed Sep 17, 2019
View reviewed changes
spec.html Outdated Show resolved Hide resolved
mathiasbynens
mathiasbynens reviewed Sep 17, 2019
View reviewed changes
spec.html Outdated Show resolved Hide resolved
mathiasbynens
mathiasbynens reviewed Sep 17, 2019
View reviewed changes
spec.html Outdated Show resolved Hide resolved
littledan
littledan reviewed Sep 17, 2019
View reviewed changes
spec.html Outdated Show resolved Hide resolved
syg
syg reviewed Oct 16, 2019
View reviewed changes
Copy link
Contributor

@syg syg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content itself lgtm.

Annex E has inconsistent formatting. I propose we format all the entries as:

1.2.3: First word capitalized with colon after the section number.

4.5.6, 7.8.9: Multiple sections referenced.

spec.html Show resolved Hide resolved
spec.html Outdated
<p><emu-xref href="#sec-reference-specification-type"></emu-xref>: In ECMAScript 2015, Function calls are not allowed to return a Reference value.</p>
<p><emu-xref href="#sec-tonumber-applied-to-the-string-type"></emu-xref>: In ECMAScript 2015, ToNumber applied to a String value now recognizes and converts |BinaryIntegerLiteral| and |OctalIntegerLiteral| numeric strings. In previous editions such strings were converted to *NaN*.</p>
<p><emu-xref href="#sec-code-realms"></emu-xref>: In ECMAScript 2018, Template objects are canonicalized based on Parse Node (source location), instead of per Realm as in previous editions.</p>
<p><emu-xref href="#sec-white-space"></emu-xref> In ECMASCript 2016, Unicode 8.0.0 or higher is mandated, as opposed to ECMAScript 2015 which mandated Unicode 5.1. In particular, this caused U+180E MONGOLIAN VOWEL SEPARATOR, which was in the `Space_Separator` (`Zs`) category and thus treated as whitespace in ECMAScript 2015, to be moved to the `Format` (`Cf`) category (as of Unicode 6.3.0). This causes whitespace-sensitive methods to behave differently. For example, `"\u180E".trim().length` was `0` in previous editions, but `1` in ECMAScript 2016 and later. Additionally, ECMAScript 2017 mandated always using the latest version of the Unicode standard.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: missing : after ref.

spec.html Outdated
@@ -42879,6 +42881,8 @@ <h1>Additions and Changes That Introduce Incompatibilities with Prior Editions</
<p><emu-xref href="#sec-regexp-pattern-flags"></emu-xref> In ECMAScript 2015, If the _pattern_ argument is a RegExp instance and the _flags_ argument is not *undefined*, a new RegExp instance is created just like _pattern_ except that _pattern_'s flags are replaced by the argument _flags_. In previous editions a *TypeError* exception was thrown when _pattern_ was a RegExp instance and _flags_ was not *undefined*.</p>
<p><emu-xref href="#sec-properties-of-the-regexp-prototype-object"></emu-xref> In ECMAScript 2015, the RegExp prototype object is not a RegExp instance. In previous editions it was a RegExp instance whose pattern is the empty string.</p>
<p><emu-xref href="#sec-properties-of-the-regexp-prototype-object"></emu-xref> In ECMAScript 2015, `source`, `global`, `ignoreCase`, and `multiline` are accessor properties defined on the RegExp prototype object. In previous editions they were data properties defined on RegExp instances.</p>
<p><emu-xref href="#sec-atomics.notify"></emu-xref> In ECMAScript 2019, `Atomics.wake` has been renamed to `Atomics.notify` to prevent confusion with `Atomics.wait`.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing :

spec.html Outdated
@@ -42879,6 +42881,8 @@ <h1>Additions and Changes That Introduce Incompatibilities with Prior Editions</
<p><emu-xref href="#sec-regexp-pattern-flags"></emu-xref> In ECMAScript 2015, If the _pattern_ argument is a RegExp instance and the _flags_ argument is not *undefined*, a new RegExp instance is created just like _pattern_ except that _pattern_'s flags are replaced by the argument _flags_. In previous editions a *TypeError* exception was thrown when _pattern_ was a RegExp instance and _flags_ was not *undefined*.</p>
<p><emu-xref href="#sec-properties-of-the-regexp-prototype-object"></emu-xref> In ECMAScript 2015, the RegExp prototype object is not a RegExp instance. In previous editions it was a RegExp instance whose pattern is the empty string.</p>
<p><emu-xref href="#sec-properties-of-the-regexp-prototype-object"></emu-xref> In ECMAScript 2015, `source`, `global`, `ignoreCase`, and `multiline` are accessor properties defined on the RegExp prototype object. In previous editions they were data properties defined on RegExp instances.</p>
<p><emu-xref href="#sec-atomics.notify"></emu-xref> In ECMAScript 2019, `Atomics.wake` has been renamed to `Atomics.notify` to prevent confusion with `Atomics.wait`.</p>
<p><emu-xref="#sec-asyncfromsynciteratorcontinuation"></emu-xref> &amp; <emu-xref href="#sec-asyncgeneratorresumenext"></emu-xref> in ECMAScript 2019, the number of Jobs enqueued by `await` was reduced, which could create an observable difference in resolution order between a `then()` call and an `await` expression.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently there's inconsistency for joining multiple section refs: ",", "and", and now &amp; in this PR. Let's decide on a consistent convention. I propose changing everything to be ",".

Also capitalize "In ECMAScript ..."

ljharb added a commit to ljharb/ecma262 that referenced this pull request Oct 17, 2019
@ljharb
Editorial: add <dfn>s for "Job" and "Job Queue" (tc39#1698)
6ae4b3e 
This will work a bit more cleanly once tc39/ecmarkup#157 lands, and "Job Queues" is picked up by ecmarkup.
ljharb added a commit to ljharb/ecma262 that referenced this pull request Oct 17, 2019
@ljharb
Editorial: update Annex E with incompatibilities from previous editio…
16f66d9 
…ns (tc39#1698)

 - 2016: the Unicode change affected what was considered whitespace (tc39#300 / 24dad16)
 - 2017: the latest version of Unicode is mandated (tc39#620)
 - 2018: changed tagged template literal objects to be cached per source location rather than per realm (tc39#890)
 - 2019: Atomics.wake was renamed to Atomics.notify (tc39#1220)
 - 2019: `await` was changed to require fewer ticks (tc39#1250)
ljharb added a commit to ljharb/ecma262 that referenced this pull request Oct 17, 2019
@ljharb
Editorial: add <dfn>s for "Job" and "Job Queue" (tc39#1698)
f85e912 
This will work a bit more cleanly once tc39/ecmarkup#157 lands, and "Job Queues" is picked up by ecmarkup.
ljharb added a commit to ljharb/ecma262 that referenced this pull request Oct 17, 2019
@ljharb
Editorial: update Annex E with incompatibilities from previous editio…
64e53a3 
…ns (tc39#1698)

 - 2016: the Unicode change affected what was considered whitespace (tc39#300 / 24dad16)
 - 2017: the latest version of Unicode is mandated (tc39#620)
 - 2018: changed tagged template literal objects to be cached per source location rather than per realm (tc39#890)
 - 2019: Atomics.wake was renamed to Atomics.notify (tc39#1220)
 - 2019: `await` was changed to require fewer ticks (tc39#1250)
@ljharb ljharb requested review from littledan, mathiasbynens, syg and a team and removed request for a team October 17, 2019 18:15
mathiasbynens
mathiasbynens reviewed Oct 18, 2019
View reviewed changes
spec.html Outdated Show resolved Hide resolved
@ljharb
Editorial: add <dfn>s for "Job" and "Job Queue" (tc39#1698)
214298c 
This will work a bit more cleanly once tc39/ecmarkup#157 lands, and "Job Queues" is picked up by ecmarkup.
@ljharb
Editorial: update Annex E with incompatibilities from previous editio…
b1593ec 
…ns (tc39#1698)

 - 2016: the Unicode change affected what was considered whitespace (tc39#300 / 24dad16)
 - 2017: the latest version of Unicode is mandated (tc39#620)
 - 2018: changed tagged template literal objects to be cached per source location rather than per realm (tc39#890)
 - 2019: Atomics.wake was renamed to Atomics.notify (tc39#1220)
 - 2019: `await` was changed to require fewer ticks (tc39#1250)
syg
syg approved these changes Oct 18, 2019
View reviewed changes
spec.html Show resolved Hide resolved
@ljharb ljharb self-assigned this Oct 18, 2019
@ljharb ljharb merged commit b1593ec into tc39:master Oct 18, 2019
@ljharb ljharb deleted the annex_e branch October 18, 2019 23:43
@jmdyck jmdyck mentioned this pull request Oct 19, 2019
Merged
@ljharb ljharb mentioned this pull request Jan 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@getify getify getify left review comments

@MayaLekova MayaLekova MayaLekova left review comments

@syg syg syg approved these changes

@devsnek devsnek devsnek approved these changes

@rwaldron rwaldron Awaiting requested review from rwaldron

@littledan littledan Awaiting requested review from littledan

Assignees

@ljharb ljharb

Labels
editorial change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ljharb @syg @mathiasbynens @getify @littledan @MayaLekova @devsnek