Normative: Add missing GetValue() to TemplateLiteral evaluation #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyGu
added
normative change
ljharb
requested changes
Aug 30, 2018
spec.html
Outdated
| 1. Let _sub_ be the result of evaluating |Expression|. | ||
| 1. ReturnIfAbrupt(_sub_). | ||
| 1. Let _subRef_ be the result of evaluating |Expression|. | ||
| 1. ReturnIfAbrupt(_subRef_). |
There was a problem hiding this comment.
this line isn't needed, since it's covered by step 1 of https://tc39.github.io/ecma262/#sec-getvalue
spec.html
Outdated
| 1. Let _sub_ be the result of evaluating |Expression|. | ||
| 1. ReturnIfAbrupt(_sub_). | ||
| 1. Let _subRef_ be the result of evaluating |Expression|. | ||
| 1. ReturnIfAbrupt(_subRef_). |
spec.html
Outdated
| 1. Let _sub_ be the result of evaluating |Expression|. | ||
| 1. ReturnIfAbrupt(_sub_). | ||
| 1. Let _subRef_ be the result of evaluating |Expression|. | ||
| 1. ReturnIfAbrupt(_subRef_). |
TimothyGu
force-pushed
the
templateliteral-getvalue
branch
from
8fc09e3
to
cebb144
Compare
|
@ljharb Fixed. |
ljharb
approved these changes
Aug 30, 2018
devsnek
approved these changes
Aug 30, 2018
bterlson
approved these changes
Sep 5, 2018
bmeck
approved these changes
Sep 5, 2018
As currently spec'd, it is an undefined behavior when an Expression that evaluates to a Reference is present in a TemplateLiteral, as the Reference value would be directly passed into ToString which expects an ECMAScript language value. Fixes tc39#935.
ljharb
force-pushed
the
templateliteral-getvalue
branch
from
cebb144
to
44e8058
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently spec'd, it is an undefined behavior when an Expression that evaluates to a Reference is present in a TemplateLiteral, as the Reference value would be directly passed into ToString which expects an ECMAScript language value.
Fixes #935.
Quite similar to #1286.