Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Symbol.prototype.description getter #1346

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

michaelficarra
Copy link
Member

This integrates the stage 3 symbol description proposal in preparation for stage 4.

As of this writing, there are three compatible browser implementations.

@michaelficarra michaelficarra added the pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. label Nov 14, 2018
@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. labels Nov 14, 2018
@ljharb ljharb requested review from bterlson, zenparsing and a team November 14, 2018 16:41
<p>`Symbol.prototype.description` is an accessor property whose set accessor function is *undefined*. Its get accessor function performs the following steps:</p>
<emu-alg>
1. Let _s_ be the *this* value.
1. Let _sym_ be ? thisSymbolValue(_s_).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also do

Let _sym_ be ? thisSymbolValue(*this* value).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reigning convention seems to be to have it in a separate variable; i don’t have a strong opinion either way as long as we’re consistent.

@michaelficarra michaelficarra removed the pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. label Nov 29, 2018
@michaelficarra
Copy link
Member Author

@tc39/ecma262-editors I've removed the pending stage 4 label.

@ljharb ljharb added es2019 has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. labels Feb 10, 2019
@bterlson bterlson merged commit 4a2d6d0 into tc39:master Feb 20, 2019
@targos targos mentioned this pull request Feb 21, 2019
14 tasks
@jmdyck jmdyck mentioned this pull request Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. normative change Affects behavior required to correctly evaluate some ECMAScript source text proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants