Editorial: Fix Completion handling for != and !== #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Jan 13, 2019
zenparsing
reviewed
Jan 14, 2019
TimothyGu
force-pushed
the
abstract-neq
branch
from
7a4fd3f
to
bf3791b
Compare
TimothyGu
changed the title
|
@zenparsing Fixed, thanks. |
zenparsing
approved these changes
May 1, 2019
|
Wait, how can Abstract Equality Comparison return an abrupt completion? |
|
If toString or valueOf throws? |
|
Ah. In that case, shouldn't its calls to |
|
Yes, that’d be a great follow up :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Abstract Equality Comparison operation may return abrupt completions, but the Strict Equality Comparison operation should always return Boolean values. Indicate that.