Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layering: Add GetRequestedModules() to Module Record #1501

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Layering: Add GetRequestedModules() to Module Record #1501

wants to merge 4 commits into from

Commits on Apr 4, 2019

  1. Add GetRequestedModules() abstract method to Cyclic Module Record, wi… 

    …th implementation for Source Text Module Record. Refactor InnerModuleInstantiation/InnerModuleEvaluation to use this instead of [[RequestedModules]] directly.
    @dandclark
    dandclark committed Apr 4, 2019
    1 Configuration menu
    Copy the full SHA
    10dfe19 View commit details
    Browse the repository at this point in the history

  2. Remove double-space, update list iteration wording, add back emu-clos… 

    …ing tag that got clipped out
    @dandclark
    dandclark committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    1b8e7f5 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2019

  1. In GetRequestedModules, allow the HostResolveImportedModule call to r… 

    …eturn an abrupt completion.
    @dandclark
    dandclark committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    6a39675 View commit details
    Browse the repository at this point in the history

  2. Move Cyclic Module Record's [[RequestedModules]] list down to Source … 

    …Text Module Record. The base type will now always use GetRequestedModules() to obtain this list.
    @dandclark
    dandclark committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    85105c5 View commit details
    Browse the repository at this point in the history