-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normative: Add Optional Chaining #1646
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Jul 25, 2019
Wavez
approved these changes
Oct 11, 2019
5c5191a
to
022a158
Compare
bakkot
reviewed
Nov 1, 2019
bakkot
reviewed
Nov 1, 2019
bakkot
reviewed
Nov 7, 2019
bakkot
reviewed
Nov 7, 2019
Could someone update this PR to reflect the upstream fixes and editorial changes? |
syg
reviewed
Nov 13, 2019
022a158
to
af15638
Compare
I've integrated the upstream changes and addressed feedback provided apart from the |
bakkot
reviewed
Nov 13, 2019
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 4, 2020
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 4, 2020
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 4, 2020
PR tc39#1646 introduced an ambiguity to the lexical grammar: Punctuator derives OtherPunctuator in two different ways -- directly, and indirectly via OptionalChainingPunctuator. It doesn't make sense for OptionalChainingPunctuator to derive OtherPunctuator, so I've eliminated that alternative.
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 5, 2020
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 5, 2020
... from non-defining production. (PR tc39#1646)
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 5, 2020
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 5, 2020
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 5, 2020
PR tc39#1646 introduced an ambiguity to the lexical grammar: Punctuator derives OtherPunctuator in two different ways -- directly, and indirectly via OptionalChainingPunctuator. It doesn't make sense for OptionalChainingPunctuator to derive OtherPunctuator, so I've eliminated that alternative.
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 13, 2020
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 13, 2020
... from non-defining production. (PR tc39#1646)
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 13, 2020
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 13, 2020
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 13, 2020
PR tc39#1646 introduced an ambiguity to the lexical grammar: Punctuator derives OtherPunctuator in two different ways -- directly, and indirectly via OptionalChainingPunctuator. It doesn't make sense for OptionalChainingPunctuator to derive OtherPunctuator, so I've eliminated that alternative.
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 13, 2020
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 13, 2020
... from non-defining production. (PR tc39#1646)
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 13, 2020
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 13, 2020
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 13, 2020
PR tc39#1646 introduced an ambiguity to the lexical grammar: Punctuator derives OtherPunctuator in two different ways -- directly, and indirectly via OptionalChainingPunctuator. It doesn't make sense for OptionalChainingPunctuator to derive OtherPunctuator, so I've eliminated that alternative.
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 15, 2020
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 15, 2020
... from non-defining production. (PR tc39#1646)
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 15, 2020
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 15, 2020
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 15, 2020
PR tc39#1646 introduced an ambiguity to the lexical grammar: Punctuator derives OtherPunctuator in two different ways -- directly, and indirectly via OptionalChainingPunctuator. It doesn't make sense for OptionalChainingPunctuator to derive OtherPunctuator, so I've eliminated that alternative.
ljharb
pushed a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 19, 2020
- insert space before paren in clause heading - eliminate grammatical parameters from non-defining production - Add 4 <emu-prodref> elements to Annex A - tweak syntax in algorithms - eliminate accidental ambiguity in Punctuator PR tc39#1646 introduced an ambiguity to the lexical grammar: Punctuator derives OtherPunctuator in two different ways -- directly, and indirectly via OptionalChainingPunctuator. It doesn't make sense for OptionalChainingPunctuator to derive OtherPunctuator, so I've eliminated that alternative. - minor grammar refactoring re Punctuator Move the Punctuator production back to its former position. (Grammars are generally written top-down.) - Fix a 'use' production for AsyncConciseBody to match the new defining production - Add an <emu-prodref> for ExpressionBody to Annex A
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 20, 2020
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
May 29, 2020
Merged
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Jun 4, 2020
ljharb
pushed a commit
to jmdyck/ecma262
that referenced
this pull request
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
has stage 4
This PR represents a proposal that has achieved stage 4, and is ready to merge.
has test262 tests
normative change
Affects behavior required to correctly evaluate some ECMAScript source text
proposal
This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the relevant updates for the stage 3 Optional Chaining proposal. The intended changes can be viewed at https://tc39.es/proposal-optional-chaining/.
The Test262 PR is available at tc39/test262#2212