Editorial: Align with the wording used elsewhere. #3097
Conversation
spec.html
Outdated
| <emu-note>This method is intentionally generic, it does not require that its *this* value be a String object. Therefore, it can be transferred to other kinds of objects for use as a method.</emu-note> | ||
| <emu-note>Similarly to `String.prototype.split`, `String.prototype.matchAll` is designed to typically act without mutating its inputs.</emu-note> | ||
| <emu-note> | ||
| <p>This method is intentionally generic; it does not require that its *this* value be a String object. Therefore, it can be transferred to other kinds of objects for use as a method.</p> | ||
| </emu-note> | ||
| <emu-note> | ||
| <p>Similarly to `String.prototype.split`, `String.prototype.matchAll` is designed to typically act without mutating its inputs.</p> | ||
| </emu-note> |
There was a problem hiding this comment.
let's revert all the lines that aren't changing any words, only changing indentation and whitespace
There was a problem hiding this comment.
I'm sorry I didn't get it. What exactly do I need to do.
Other place has a p tag embedded in it, so I added it here.
There was a problem hiding this comment.
There's no need for that, I think.
There was a problem hiding this comment.
(An <emu-note> with a single paragraph of content usually puts it in a <p> element: ~550 have it vs ~20 don't.)
There was a problem hiding this comment.
This PR might also include the two "intentionally generic factory method" notes in its scope.
Re changing
<emu-note>
<p>Foo</p>
</emu-note>
to just
<emu-note>Foo</emu-note>
It's 'valid', but I'm not sure it's an improvement. (@michaelficarra's thumbs-up on #3097 (comment) suggests a preference to use the former, but you might as well wait for an explicit indication.)
The other changes (punctuation, wording, blank-line removal) seem okay to me.
spec.html
Outdated
| <emu-note> | ||
| <p>Similarly to `String.prototype.split`, `String.prototype.matchAll` is designed to typically act without mutating its inputs.</p> | ||
| </emu-note> |
There was a problem hiding this comment.
The change to this note seems out-of-place in this PR.
|
This needs to be rebased (not closed and reopened, please) |
|
done? But I don't know why he turned it off automatically and then I had to turn it back on |
reduce reading distractions