Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: fail IPR check on commits with unknown authors #3128

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Meta: fail IPR check on commits with unknown authors #3128

merged 4 commits into from
Jul 26, 2023

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Jul 24, 2023

This was a case I hadn't considered - #3097, specifically, where the commits in the PR aren't actually linked to the user's github.

@ljharb ljharb added the meta label Jul 24, 2023
@ljharb ljharb requested a review from a team July 24, 2023 21:08
@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Jul 24, 2023
@michaelficarra
Copy link
Member

I want to talk about our strategy here in editor call.

ljharb added a commit to ljharb/ecma262 that referenced this pull request Jul 24, 2023
@ljharb
Meta: fail IPR check on commits with unknown authors (tc39#3128)
0a5e5dc
ljharb added a commit to ljharb/ecma262 that referenced this pull request Jul 24, 2023
@ljharb
Meta: fail IPR check on commits with unknown authors (tc39#3128)
c2fd775
@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Jul 26, 2023
@ljharb ljharb removed the editor call to be discussed in the next editor call label Jul 26, 2023
@ljharb ljharb merged commit a524f33 into tc39:main Jul 26, 2023
9 of 11 checks passed
@ljharb ljharb deleted the ipr-check-redux branch July 26, 2023 22:18
zhangenming pushed a commit to zhangenming/ecma262 that referenced this pull request Dec 22, 2023
@ljharb @zhangenming
Revert "Editorial: Correct GetExportedNames return type (tc39#3127)" (t…
e8ad0d2 
…c39#3128)

This reverts commit 57f427b.
zhangenming pushed a commit to zhangenming/ecma262 that referenced this pull request Dec 22, 2023
@ljharb @zhangenming
Revert "Editorial: Correct ExportEntry.[[LocalName]] description (tc3…
f6ec90e 
…9#3126)" (tc39#3128)

This reverts commit 6e2f689.
zhangenming pushed a commit to zhangenming/ecma262 that referenced this pull request Dec 22, 2023
@ljharb @zhangenming
Revert "Editorial: Correct desiderable to desirable (tc39#3125)" (tc3…
f19624f 
…9#3128)

This reverts commit a103b28.
zhangenming pushed a commit to zhangenming/ecma262 that referenced this pull request Dec 22, 2023
@ljharb @zhangenming
Meta: fail IPR check on commits with unknown authors (tc39#3128)
643ffa7 
 - also, compare everything in lowercase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
meta ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ljharb @michaelficarra @bakkot