Normative: Update GetSubstitution to match reality #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
added
needs consensus
|
This appears to already have a test: https://github.com/tc39/test262/blob/1a0b9d23f241abc2f0abf73cc397f3390c7d9960/test/built-ins/String/prototype/replace/S15.5.4.11_A3_T1.js |
michaelficarra
added
has test262 tests
and removed
needs test262 tests
|
I guess we should also have a test for when the first digit alone still exceeds the number of captures, like |
michaelficarra
added
the
needs test262 tests
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
michaelficarra
approved these changes
Sep 27, 2023
michaelficarra
added
has consensus
ljharb
removed
the
needs test262 tests
bakkot
approved these changes
Oct 12, 2023
bakkot
added
the
ready to merge
$nn patterns fall back to $n when there aren't at least nn captures Fixes tc39#1426
ljharb
force-pushed
the
gh-1426-getsubstitution-dollar-nn-2
branch
from
1e0e4c8
to
5eaee2f
Compare
zhangenming
pushed a commit
to zhangenming/ecma262
that referenced
this pull request
Dec 22, 2023
$nn patterns fall back to $n when there aren't at least nn captures Fixes tc39#1426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$nn patterns fall back to $n when there aren't at least nn captures
Fixes gh-1426
test262 PR: tc39/test262#3931