Editorial: Remove duplicate "current Realm" variable from CreateDynamicFunction #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
Sep 30, 2023
syg
approved these changes
Oct 18, 2023
bakkot
approved these changes
Oct 22, 2023
bakkot
added
the
ready to merge
ljharb
force-pushed
the
remove-duplicate-var-from-createdynamicfunction
branch
from
3b3bfd9
to
3d7c44c
Compare
zhangenming
pushed a commit
to zhangenming/ecma262
that referenced
this pull request
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given
currentRealmis declared at the step 1 ofCreateDynamicFunction, and that running execution context won't change untilrealmFdeclaration (step 23), it's more clear and sensible to reuse thecurrentRealmvariable.