Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypedArrays.prototype.constructor reference #349

Closed

Conversation

leobalter
Copy link
Member

Fix the reference so a Float32Array.prototype.constructor references the
corresponding Float32Array object, etc.

The %TypedArray% constructor is not called anymore and it should not be
the reference for TypedArray instances

Fix the reference so a Float32Array.prototype.constructor references the
corresponding Float32Array object, etc.

The %TypedArray% constructor is not called anymore and it should not be
the reference for TypedArray instances
@anba
Copy link
Contributor

anba commented Feb 3, 2016

%_TypedArray_% is actually correct in this context, because _TypedArray_ refers to the current TypedArray instantiation. So when TypedArray is the constructor name "Float64Array", %TypedArray% (%_TypedArray_%) is the intrinsic object %Float64Array%.

That being said, we should probably just pick a different variable name for TypedArray.

@leobalter
Copy link
Member Author

You're right.

That being said, we should probably just pick a different variable name for TypedArray.

Yes. I'll need to bring it to another PR / issue.

@leobalter leobalter closed this Feb 3, 2016
@leobalter leobalter deleted the typedarray-prototype-constructor branch February 3, 2016 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants