RegExp.prototype not an instance web compatibility workaround #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes a change to ES2015 RegExp semantics to prevent certain property accesses and method calls from throwing. Although the feature testing patterns here are dispreferred, they were found necessary to ensure web compatibility of ES2015-based RegExp semantics with respect to old versions of certain libraries. This closes tc39#262.
| @@ -28965,7 +28965,9 @@ | |||
| <emu-alg> | |||
| 1. Let _R_ be the *this* value. | |||
| 1. If Type(_R_) is not Object, throw a *TypeError* exception. | |||
| 1. If _R_ does not have an [[OriginalFlags]] internal slot, throw a *TypeError* exception. | |||
| 1. If _R_ does not have an [[OriginalFlags]] internal slot, | |||
| 1. If SameValue(_R_, %RegExpPrototype%), return *undefined*. | |||
There was a problem hiding this comment.
If SameValue... is true, I think :)
There was a problem hiding this comment.
Also, "then return undefined" is probably more consistent.
There was a problem hiding this comment.
undefined is correct I think (tho maybe I am missing what you were saying)
There was a problem hiding this comment.
I think @annevk meant to say “then” is missing.
|
Whoops, didn't mean to go through with the merge (was just testing the new setting). I will fix up the style issues I noted now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes a change to ES2015 RegExp semantics to prevent
certain property accesses and method calls from throwing. Although
the feature testing patterns here are dispreferred, they were found
necessary to ensure web compatibility of ES2015-based RegExp
semantics with respect to old versions of certain libraries.
This closes #262.
This patch attempts to encode the consensus of the March 2016 TC39 meeting.