Trailing commas in function param and call lists #711
Conversation
| 1. Return _names_. | ||
| 1. Let _names_ be BoundNames of |FormalParameterList| | ||
| 1. Append to _names_ the BoundNames of |FunctionRestParameter| | ||
| 1. Return _names_ |
| 1. Let _status_ be the result of performing IteratorBindingInitialization for |FormalsList| using _iteratorRecord_ and _environment_ as the arguments. | ||
| 1. ReturnIfAbrupt(_status_). | ||
| 1. Let _restIndex_ be the result of performing IteratorBindingInitialization for |FormalParameterList| using _iteratorRecord_ and _environment_ as the arguments. | ||
| 1. ReturnIfAbrupt(_restIndex_). |
There was a problem hiding this comment.
this change is not wrong but neither necessary. status would be fine.
No need to revert, but is there any specific reason for this change?
There was a problem hiding this comment.
Oh, I think this was just me copying the algo from FormalParameters : FormalParameterList,FunctionRestParameter right above (and me deleting FormalsList before realizing I needed to replace it).
Anyway, status does make more sense. Will switch it back
The [function trailing commas proposal](https://tc39.github.io/proposal-trailing-function-commas/) is now Stage 4, so this PR updates the spec text to reflect it. Please review carefully as I'm fairly noobish at merging ecmaspeak.
|
Updated to address @leobalter's feedback |
|
cc @bterlson -- I guess you're the one who needs to review this before merging? |
|
@jeffmo I'll hit the merge button once I've reviewed, don't worry. Next week once I'm back! |
|
Tests are in, I've reviewed yet again, pulling this in. |
|
Sorry had to reconvince myself that the grammar works :-P |
The function trailing commas proposal
is now Stage 4, so this PR updates the spec text to reflect it.
Please review carefully as I'm fairly noobish at merging ecmaspeak.