Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SharedArrayBuffer & Atomics #769

Closed
wants to merge 15 commits into from

Conversation

Projects
None yet
3 participants
@bterlson
Copy link
Member

commented Jan 20, 2017

This PR moves the contents from ecmascript_sharedmem in advance of stage 4 approval next week. Minor editorial updates (and minor bug fixes) were made but otherwise no changes.

Test262 updates are pending.

@bterlson

This comment has been minimized.

Copy link
Member Author

commented Jan 20, 2017

@syg

This comment has been minimized.

Copy link
Contributor

commented Jan 21, 2017

Here's the test262 PR: tc39/test262#839

bterlson and others added some commits Jan 19, 2017

Normative: integrate SharedArrayBuffer proposal sections 6.3.4 to 6.3…
….6 as notes at the end of the memory model section
Editorial: SAB editorial tweaks (#782)
* Editorial: put Memory Model notes in their own subclause

The emu-clause for "Memory Model" contains some introductory stuff,
followed by a bunch of sub-emu-clauses,
followed by 3 emu-notes.
Now, although these notes are (in the HTML)
children of the Memory Model clause,
I suspect that when rendered,
they'll *look* like they're part of
the last of the sub-clauses ("Data Race Freedom"),
which you probably don't want.

So, to prevent this, I put the three notes in their own sub-clause.

* Editorial: in <li> with block items, put inline items in <p>

It's unusual (at least in this document)
for a <li> to contain both inline items (<em> and text) and block items (<p>).
Embed the inline items in a <p>.

(Also, adjust the linebreaking and indenting accordingly.)

* Editorial: Add </li> tags

* Editorial: insert missing </emu-xref> tag

* Editorial: fix misspelled </emu-xref> tag

* Editorial: insert missing close-backticks

* Editorial: put missing underscores around metavariables

* Editorial: put missing asterisks around "true"

* Editorial: put missing backticks around string literal

* Editorial: insert missing "that"

* Editorial: change "the List" to "a List" in a few places

* Editorial: various wording tweaks re empty List

"the empty list" -> "a new empty List" or "an empty List" as appropriate

"an empty List"  -> "a new empty List"

* Editorial: remove asterisks from *0* and *1*

For one thing, 0 (per se) doesn't exist as an ES value.
More generally, spec algorithms can use abstract/mathematical integers
without having to relate them to Number values.

* Editorial: add "Record" to anonymous record constructors

(Should maybe be "Chosen Value Record".)

* Editorial: delete pointless Zero-Width Joiner

* Editorial: remove extra indent on 2 algorithm steps

* Editorial: insert and delete a few spaces

* Editorial: insert comma before "then"

* Editorial: misc tweaks to algorithm wording

... mostly for consistency

* Editorial: change "a event" to "an event"

* Editorial: disambiguate a dangling else

This is a case of "dangling else" (or "dangling otherwise"),
and it's not obvious which "if" the "otherwise" associates with.

I've rewritten it to remove the ambiguity.
Please check whether I got the intent right.
(If not, you might want to rewrite as multiple steps,
so that the logic is clear.)

@bterlson bterlson force-pushed the sab-integration branch from 7ef4f1d to d617a6e Feb 1, 2017

@bterlson

This comment has been minimized.

Copy link
Member Author

commented Feb 2, 2017

This has been merged.

@bterlson bterlson closed this Feb 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.