-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToDateTimeOptions should avoid making an observable internal-use object #706
Labels
c: datetime
Component: dates, times, timezones
s: help wanted
Status: help wanted; needs proposal champion
Milestone
Comments
#237 (comment) has a link to patch which avoids creating an intermediate object. |
Fixed in #709. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: datetime
Component: dates, times, timezones
s: help wanted
Status: help wanted; needs proposal champion
(created from #493 (comment) )
ToDateTimeOptions creates an object inheriting from provided options and performs some observable writes upon it, which is unnecessarily weird.
The text was updated successfully, but these errors were encountered: