Normative: Treat -0 as negative in NumberFormat #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would anyone be interested in writing test262 tests for this change? @anba @jackhorton @Ms2ger |
|
This test would now be possible because of the required data frontmatter? Not sure how to test this other than to actually inspect the string coming out of format and/or the minusSign part coming out of formatToParts. |
ljharb
approved these changes
Jun 11, 2018
Ms2ger
added a commit
to Ms2ger/test262
that referenced
this pull request
Jul 6, 2018
The specification was updated in tc39/ecma402#232.
|
Test: tc39/test262#1628 |
|
OK, has anyone implemented this in a JS engine? Now that there's a test262 test, it should be easier to verify. |
Ms2ger
added a commit
to Ms2ger/test262
that referenced
this pull request
Jul 27, 2018
The specification was updated in tc39/ecma402#232.
rwaldron
pushed a commit
to tc39/test262
that referenced
this pull request
Jul 27, 2018
The specification was updated in tc39/ecma402#232.
|
@jackhorton reported in July's meeting notes that this change is implemented in ChakraCore. Between the tests, the change, and the implementation experience. this patch is ready to land. |
sffc
added a commit
to tc39/proposal-unified-intl-numberformat
that referenced
this pull request
Jul 30, 2018
See #13. Merges change from tc39/ecma402#232 into Unified Intl.NumberFormat proposal.
|
I merged the change to the corresponding spot in my proposal. |
brn
pushed a commit
to brn/v8
that referenced
this pull request
Jan 12, 2019
The spec changed in 7/2018 to treat -0 and 0 differently. tc39/ecma402#232 Bug: v8:7474, v8:8099 Change-Id: I77db4ae716b081b7628dc7ee253a463520c7f6e9 Reviewed-on: https://chromium-review.googlesource.com/c/1400403 Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58645}
chicoxyzzy
pushed a commit
to chicoxyzzy/test262
that referenced
this pull request
May 14, 2019
The specification was updated in tc39/ecma402#232.
chicoxyzzy
pushed a commit
to chicoxyzzy/test262
that referenced
this pull request
May 14, 2019
The specification was updated in tc39/ecma402#232.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #219