Add dynamic import.defer() syntax to mirror import.source()
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acutmore
reviewed
Jan 16, 2024
spec.emu
Outdated
| 1. Perform ! Call(_promiseCapability_.[[Resolve]], *undefined*, « _namespace_ »). | ||
| 1. Return ~unused~. | ||
| 1. <ins>If _phase_ is ~defer~, then</ins> | ||
| 1. <ins>Perform _fulfilledClosure_().</ins> |
There was a problem hiding this comment.
I'm probably missing this as I'm nowhere near as familiar with this flow as you are, but I'm missing that part where we do GatherAsynchronousTransitiveDependencies and evaluate those before fulfilling this promise.
There was a problem hiding this comment.
You are missing it as it's indeed missing 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @acutmore since you mentioned this the other day :)