Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Always throw when style: "numeric" and display: "always" used on sub-second units #178

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Normative: Always throw when style: "numeric" and display: "always" used on sub-second units #178

merged 5 commits into from
Jan 5, 2024

Conversation

ben-allen
Copy link
Collaborator

@ben-allen ben-allen commented Nov 13, 2023 •
edited

fix #155

1bfcb45 incorporates anba's suggestion from issue
42730c0 small typo fix

@sffc sffc added consensus We reached a consensus in a discussion meeting, through email or the issue discussion needs-tg1 labels Nov 16, 2023
@sffc
Copy link
Collaborator

sffc commented Nov 16, 2023

TG2 approval: https://github.com/tc39/ecma402/blob/master/meetings/notes-2023-11-16.md#getdurationunitoptions-always-throw-when-numeric-sub-seconds-are-used-with-display-always-155

@ryzokuken
Copy link
Member

2023-11-28: This PR achieved TC39-TG1 consensus.

@ben-allen ben-allen merged commit 1dea7a7 into tc39:main Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
consensus We reached a consensus in a discussion meeting, through email or the issue discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetDurationUnitOptions: Always throw when "numeric" sub-seconds are used with display "always"
3 participants
@ben-allen @sffc @ryzokuken