Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #13: add String.prototype.toWellFormed #20

Merged
merged 4 commits into from
Sep 13, 2022
Merged

fixes #13: add String.prototype.toWellFormed #20

merged 4 commits into from
Sep 13, 2022

Conversation

michaelficarra
Copy link
Member

Fixes #13.

@michaelficarra michaelficarra mentioned this pull request Aug 26, 2022
Closed
ljharb
ljharb approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comment

spec.html Show resolved Hide resolved
@michaelficarra
Copy link
Member Author

Committee was in favour of including toWellFormed.

@michaelficarra michaelficarra merged commit f91aaa4 into main Sep 13, 2022
@michaelficarra michaelficarra deleted the towellformed branch September 13, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@bakkot bakkot bakkot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add toUSVString / toWellFormed (alongside isUSVString / isWellFormed)
3 participants
@michaelficarra @ljharb @bakkot