This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
[Refactor] rewrite the spec text so that .finally
observably calls .then
#14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR demonstrating the spec refactor that makes
.finally
, like.catch
, observably call into.then
.Pros:
.catch
.then
(which might be useful in particular because the callback logic infinally
is complex)Cons:
[[Get]]
and[[Call]]
of"then"
new Promise
executor'sresolve
andreject
function), thus preventing them from being optimized out in implementations.