Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DifferenceZonedDateTime: precalculatedPlainDateTime is never undefined #2822

Closed
anba opened this issue Apr 17, 2024 · 2 comments
Closed

DifferenceZonedDateTime: precalculatedPlainDateTime is never undefined #2822

anba opened this issue Apr 17, 2024 · 2 comments
Assignees
@ptomato
Labels
editorial spec-text Specification text involved

Comments

@anba
Copy link
Contributor

anba commented Apr 17, 2024

The precalculatedPlainDateTime parameter of DifferenceZonedDateTime is never undefined:

  1. When called from DifferenceTemporalZonedDateTime, then step 13 creates a Temporal.PlainDateTime.
  2. When called from AddDuration, then startDateTimeNeeded is set to true in step 10, so steps 11-12 set startDateTime to a Temporal.PlainDateTime.
@ptomato ptomato self-assigned this Apr 17, 2024
@ptomato ptomato added spec-text Specification text involved editorial labels Apr 17, 2024
ptomato added a commit that referenced this issue Apr 26, 2024
@ptomato
Editorial: Tighten argument type in DifferenceZonedDateTime
3264454 
Anba pointed out that it is never undefined.

Closes: #2822
ptomato added a commit that referenced this issue Apr 26, 2024
@ptomato
Editorial: Tighten argument type in DifferenceZonedDateTime
a8ce60a 
Anba pointed out that it is never undefined.

Closes: #2822
ptomato added a commit that referenced this issue Apr 27, 2024
@ptomato
Editorial: Tighten argument type in DifferenceZonedDateTime
6a7f739 
Anba pointed out that it is never undefined.

Closes: #2822
@Ms2ger Ms2ger closed this as completed in 3f4bca3 Apr 29, 2024
@anba
Copy link
Contributor Author

anba commented May 3, 2024

3f4bca3 only updated the argument types, but kept step 2 of DifferenceZonedDateTime:

  1. If precalculatedPlainDateTime is undefined, then

This step should also be removed.

@ptomato
Copy link
Collaborator

ptomato commented May 3, 2024

Thanks, will get this in the next batch of fixes.

ptomato added a commit that referenced this issue May 3, 2024
@ptomato
Editorial: Remove unused algorithm steps
d437c4b 
Follow up from #2822. Once again thanks to Anba for spotting this.
Ms2ger pushed a commit that referenced this issue May 6, 2024
@ptomato @Ms2ger
Editorial: Remove unused algorithm steps
c0be58d 
Follow up from #2822. Once again thanks to Anba for spotting this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
editorial spec-text Specification text involved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptomato @anba