Normative: Fix undefined variables in HandleDateTimeValue #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the PlainDate, PlainDateTime, PlainMonthDay, PlainTime, and PlainYearMonth cases, the _timeZone_ variable was never set before it was used. This is an error in the spec text. It should be equal to the time zone in the DateTimeFormat's resolvedOptions. Add tests proving that this time zone is used when converting the Plain objects to exact time, so that the wall time in the same time zone is used when formatting them.
ptomato
added
the
needs plenary input
|
Converting to draft so that the normative change is not accidentally merged. |
Codecov Report
@@ Coverage Diff @@
## main #1687 +/- ##
==========================================
- Coverage 95.03% 91.09% -3.94%
==========================================
Files 19 17 -2
Lines 10785 10774 -11
Branches 1725 1608 -117
==========================================
- Hits 10249 9815 -434
- Misses 523 945 +422
- Partials 13 14 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This change achieved consensus in TC39. @Ms2ger Mind taking a final look? |
Ms2ger
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PlainDate, PlainDateTime, PlainMonthDay, PlainTime, and
PlainYearMonth cases, the timeZone variable was never set before it was
used. This is an error in the spec text. It should be equal to the
time zone in the DateTimeFormat's resolvedOptions.
Add tests proving that this time zone is used when converting the Plain
objects to exact time, so that the wall time in the same time zone is used
when formatting them.