Normative: Optimize calls into user code in InterpretISODateTimeOffset #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
added
the
needs plenary input
Codecov Report
@@ Coverage Diff @@
## main #1688 +/- ##
==========================================
+ Coverage 90.09% 91.10% +1.00%
==========================================
Files 17 17
Lines 10896 10777 -119
Branches 1617 1608 -9
==========================================
+ Hits 9817 9818 +1
+ Misses 1041 945 -96
+ Partials 38 14 -24
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Marking as draft so that the normative change isn't merged accidentally. |
|
This change achieved consensus in TC39. @Ms2ger Would you be able to take a final look? |
Ms2ger
approved these changes
Sep 2, 2021
Ms2ger
force-pushed
the
optimize-interpretisodatetimeoffset
branch
from
d4b1539
to
50d5af8
Compare
In the current spec text algorithm, there was an unnecessary call to timeZone.getPossibleInstantsFor(), which potentially calls observably into user code. Fix the algorithm so it doesn't make any more calls than necessary.
Ms2ger
force-pushed
the
optimize-interpretisodatetimeoffset
branch
from
50d5af8
to
4409765
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current spec text algorithm, there was an unnecessary call to
timeZone.getPossibleInstantsFor(), which potentially calls observably into
user code. Fix the algorithm so it doesn't make any more calls than
necessary.