Normative: Add missing RequireInternalSlot #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1693 +/- ##
===========================================
- Coverage 95.03% 72.89% -22.14%
===========================================
Files 19 18 -1
Lines 10785 4840 -5945
Branches 1725 1058 -667
===========================================
- Hits 10249 3528 -6721
- Misses 523 1030 +507
- Partials 13 282 +269
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
FrankYFTang
changed the title
|
Sorry, I should mark this as draft, pending my action in #1692. |
|
We'll present this one at the December TC39 plenary. |
ljharb
approved these changes
Oct 29, 2021
ptomato
added
the
needs plenary input
Ms2ger
approved these changes
Dec 3, 2021
|
This achieved consensus at the December 2021 TC39 meeting. |
jessealama
added a commit
to jessealama/proposal-temporal
that referenced
this pull request
Jan 7, 2022
References: + tc39#1693
ptomato
pushed a commit
to ptomato/test262
that referenced
this pull request
Feb 4, 2022
tc39/proposal-temporal#1693 added checks for the receiver of certain Temporal.Calendar and Temporal.TimeZone methods. Add branding tests for these methods, similar to the already existing branding tests. This was a normative change that achieved consensus at the December 2021 TC39 meeting.
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Feb 4, 2022
A follow up to the previous commit, this rewrites some tests that relied on the lack of brand checks for certain Temporal.TimeZone methods. tc39/proposal-temporal#1693 added brand checks to these methods. We can no longer use a plain object time zone or even a Proxy with a real branded Temporal.TimeZone object as its handler to do these tests, so we instead create an instance of Temporal.TimeZone and define own accessor properties on it in order to test the observable property accesses that we need to see according to the spec text. This requires an improvement to TemporalHelpers.observeProperty() in order to be able to log property accesses to Symbol-valued properties.
ptomato
pushed a commit
to ptomato/test262
that referenced
this pull request
Feb 5, 2022
tc39/proposal-temporal#1693 added checks for the receiver of certain Temporal.Calendar and Temporal.TimeZone methods. Add branding tests for these methods, similar to the already existing branding tests. This was a normative change that achieved consensus at the December 2021 TC39 meeting.
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Feb 5, 2022
A follow up to the previous commit, this rewrites some tests that relied on the lack of brand checks for certain Temporal.TimeZone methods. tc39/proposal-temporal#1693 added brand checks to these methods. We can no longer use a plain object time zone or even a Proxy with a real branded Temporal.TimeZone object as its handler to do these tests, so we instead create an instance of Temporal.TimeZone and define own accessor properties on it in order to test the observable property accesses that we need to see according to the spec text. This requires an improvement to TemporalHelpers.observeProperty() in order to be able to log property accesses to Symbol-valued properties.
rwaldron
pushed a commit
to tc39/test262
that referenced
this pull request
Feb 8, 2022
tc39/proposal-temporal#1693 added checks for the receiver of certain Temporal.Calendar and Temporal.TimeZone methods. Add branding tests for these methods, similar to the already existing branding tests. This was a normative change that achieved consensus at the December 2021 TC39 meeting.
rwaldron
pushed a commit
to tc39/test262
that referenced
this pull request
Feb 8, 2022
A follow up to the previous commit, this rewrites some tests that relied on the lack of brand checks for certain Temporal.TimeZone methods. tc39/proposal-temporal#1693 added brand checks to these methods. We can no longer use a plain object time zone or even a Proxy with a real branded Temporal.TimeZone object as its handler to do these tests, so we instead create an instance of Temporal.TimeZone and define own accessor properties on it in order to test the observable property accesses that we need to see according to the spec text. This requires an improvement to TemporalHelpers.observeProperty() in order to be able to log property accesses to Symbol-valued properties.
ptomato
pushed a commit
to jessealama/proposal-temporal
that referenced
this pull request
Feb 9, 2022
References: + tc39#1693
jessealama
added a commit
to jessealama/proposal-temporal
that referenced
this pull request
Feb 15, 2022
References: + tc39#1693
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1692
I assume these missing RequireInternalSlot is mistake.