Normative: Ensure an Object is returned from calendar.mergeFields() #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1719 +/- ##
===========================================
- Coverage 90.11% 72.90% -17.21%
===========================================
Files 17 18 +1
Lines 10771 4842 -5929
Branches 1611 1059 -552
===========================================
- Hits 9706 3530 -6176
- Misses 1029 1030 +1
- Partials 36 282 +246
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Marking as draft so the normative change is not merged without consensus. |
ljharb
approved these changes
Aug 12, 2021
In each case where CalendarMergeFields is called, it is later asserted in PrepareTemporalFields that Type(_fields_) is Object. Previously the spec text failed this assertion. The tests check that a TypeError is thrown in this case, as well as that the TypeError is thrown before the value is passed to any dateFromFields() or similar method.
ptomato
force-pushed
the
1669-mergefields-return
branch
from
67a4c4d
to
adddcd2
Compare
|
This change achieved consensus in TC39. @Ms2ger Would you be able to take a final look? |
Ms2ger
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In each case where CalendarMergeFields is called, it is later asserted in
PrepareTemporalFields that Type(fields) is Object. Previously the spec
text failed this assertion.
The tests check that a TypeError is thrown in this case, as well as that
the TypeError is thrown before the value is passed to any dateFromFields()
or similar method.