Normative: Consistent order of operations in PMD.toPD and PYM.toPD #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1734 +/- ##
==========================================
- Coverage 94.85% 91.10% -3.76%
==========================================
Files 19 17 -2
Lines 10882 10776 -106
Branches 1729 1610 -119
==========================================
- Hits 10322 9817 -505
- Misses 547 945 +398
- Partials 13 14 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Draft, in order to avoid accidentally merging before presenting for consensus |
ljharb
approved these changes
Aug 16, 2021
|
This change achieved consensus in TC39. @Ms2ger would you be able to take a final look? |
Ms2ger
approved these changes
Sep 2, 2021
The spec text was inconsistent about whether the type check on the argument or the calendar.fields checks should occur first. In Temporal.PlainMonthDay.prototype.toPlainDate, the fields checks were first. In Temporal.PlainYearMonth.prototype.toPlainDate, the type check was first. This changes the PlainMonthDay algorithm to match the PlainYearMonth one, and adds tests to both.
Ms2ger
force-pushed
the
1702-plainmonthday-toplaindate-type-check
branch
from
0af998c
to
1a99004
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec text was inconsistent about whether the type check on the
argument or the calendar.fields checks should occur first. In
Temporal.PlainMonthDay.prototype.toPlainDate, the fields checks were
first. In Temporal.PlainYearMonth.prototype.toPlainDate, the type check
was first. This changes the PlainMonthDay algorithm to match the
PlainYearMonth one, and adds tests to both.
Closes: #1702