Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of ES.CalendarEquals #1858

Merged
merged 1 commit into from Oct 5, 2021
Merged

Fix usage of ES.CalendarEquals #1858

merged 1 commit into from Oct 5, 2021

Conversation

justingrant
Copy link
Collaborator

TS found a bug in several callers of CalendarEquals. This bug didn't break any tests because it only executed when non-calendar units were equal, but the new code matches the spec.

Also, including the Test262 submodule broke my git repo, so I had to re-clone my local repo from GitHub. When I ran npm install after doing this, there was a one-line change made in package-lock.json. I assume this is OK.

@justingrant
Copy link
Collaborator Author

FYI @12wrigja as you're working on those files over in @js-temporal/temporal-polyfill.

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #1858 (92ae1ea) into main (1cde28d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1858   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files          19       19           
  Lines       10969    10969           
  Branches     1712     1712           
=======================================
  Hits        10397    10397           
  Misses        557      557           
  Partials       15       15           
Flag Coverage Δ
test262 81.23% <75.00%> (ø)
tests 89.42% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/plaindate.mjs 90.26% <100.00%> (ø)
polyfill/lib/plaindatetime.mjs 97.30% <100.00%> (ø)
polyfill/lib/plainmonthday.mjs 87.16% <100.00%> (ø)
polyfill/lib/plainyearmonth.mjs 95.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cde28d...92ae1ea. Read the comment docs.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is correct. (I'm not sure what caused the diff in package-lock.json; maybe a different npm version?)

@ptomato ptomato added the no-spec-text PR can be ignored by implementors label Oct 5, 2021
@ptomato ptomato merged commit 2959043 into main Oct 5, 2021
@ptomato ptomato deleted the calendar-equals-usage branch October 5, 2021 17:10
justingrant added a commit to justingrant/temporal-polyfill that referenced this pull request Oct 5, 2021
justingrant added a commit to justingrant/temporal-polyfill that referenced this pull request Oct 5, 2021
12wrigja pushed a commit to js-temporal/temporal-polyfill that referenced this pull request Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-spec-text PR can be ignored by implementors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants