Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Fix precision 0 issue in TemporalDurationToString #1860

Merged
merged 1 commit into from Oct 29, 2021

Conversation

FrankYFTang
Copy link
Contributor

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #1860 (b433ba2) into main (2959043) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1860   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files          19       19           
  Lines       10969    10969           
  Branches     1712     1712           
=======================================
  Hits        10397    10397           
  Misses        557      557           
  Partials       15       15           
Flag Coverage Δ
test262 81.23% <ø> (ø)
tests 89.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2959043...b433ba2. Read the comment docs.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It sounds like there are already test262 tests in the tree that cover this.

I'll convert this to draft and present it at the upcoming TC39 meeting.

@ptomato ptomato marked this pull request as draft October 7, 2021 17:06
@FrankYFTang
Copy link
Contributor Author

It sounds like there are already test262 tests in the tree that cover this.

Yes, the changed behavior is already tested under

built-ins/Temporal/Duration/prototype/toString/smallestunit-valid-units.js
built-ins/Temporal/Duration/prototype/toString/blank-duration-precision.js
built-ins/Temporal/Duration/prototype/toString/roundingmode-undefined.js

but not aligned with the current spec text unless we take this PR.

@ptomato ptomato added the spec-text Specification text involved label Oct 8, 2021
@ptomato ptomato marked this pull request as ready for review October 29, 2021 18:33
@ptomato
Copy link
Collaborator

ptomato commented Oct 29, 2021

This gained consensus in the October TC39 plenary.

@ptomato ptomato merged commit d97231c into tc39:main Oct 29, 2021
@FrankYFTang FrankYFTang deleted the patch-5 branch October 29, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-text Specification text involved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants