Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Allow non-402 implementations to support non-iso8601 calendars #2193

Merged
merged 6 commits into from Jun 13, 2022

Conversation

gibson042
Copy link
Collaborator

Fixes #2192

@gibson042 gibson042 added behavior Relating to behavior defined in the proposal spec-text Specification text involved meeting-agenda calendar Part of the effort for Temporal Calendar API normative Would be a normative change to the proposal labels May 12, 2022
@gibson042 gibson042 requested a review from ptomato May 12, 2022 14:32
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #2193 (7eae1fd) into main (7eae1fd) will not change coverage.
The diff coverage is n/a.

❗ Current head 7eae1fd differs from pull request most recent head 7a58b02. Consider uploading reports for the commit 7a58b02 to get more accurate results

@@           Coverage Diff           @@
##             main    #2193   +/-   ##
=======================================
  Coverage   91.08%   91.08%           
=======================================
  Files          19       19           
  Lines       10558    10558           
  Branches     1695     1695           
=======================================
  Hits         9617     9617           
  Misses        931      931           
  Partials       10       10           
Flag Coverage Δ
test262 83.46% <0.00%> (ø)
tests 81.84% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eae1fd...7a58b02. Read the comment docs.

1. Return « *"iso8601"* ».
</emu-alg>
<p>
This function returns a List of String values representing calendar types supported by the implementation. The contents of the List are implementation-defined, but must contain *"iso8601"* and must not contain any String value that does not identify a calendar type in the <a href="https://cldr.unicode.org/">Unicode Common Locale Data Repository (CLDR)</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this! perhaps this could be represented as explicit algorithm steps doing these assertions, and then using the prose in the "return" step?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.

@ljharb
Copy link
Member

ljharb commented May 12, 2022

LGTM!

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, assuming we do want to propose this normative change — I'll comment on #2192.

@ptomato ptomato marked this pull request as draft May 12, 2022 19:11
@ptomato
Copy link
Collaborator

ptomato commented May 12, 2022

Draft until presented to TC39 plenary.

@ptomato ptomato force-pushed the gh-2192-allow-calendars-without-402 branch from 8a3c47b to 7a58b02 Compare June 13, 2022 17:15
@ptomato ptomato marked this pull request as ready for review June 13, 2022 17:15
@ptomato
Copy link
Collaborator

ptomato commented Jun 13, 2022

This achieved consensus at the June 2022 TC39 plenary meeting.

@ptomato ptomato merged commit 5b9d76a into tc39:main Jun 13, 2022
ptomato added a commit that referenced this pull request Apr 30, 2024
This should have been part of #2193 but was forgotten. If a non-402
implementation is allowed to support more than just the iso8601 calendar,
then it will need to have era/eraYear properties.
Ms2ger pushed a commit that referenced this pull request May 2, 2024
This should have been part of #2193 but was forgotten. If a non-402
implementation is allowed to support more than just the iso8601 calendar,
then it will need to have era/eraYear properties.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior Relating to behavior defined in the proposal calendar Part of the effort for Temporal Calendar API normative Would be a normative change to the proposal spec-text Specification text involved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should built-in calendars of non-Intl implementations be limited to "iso8601"?
4 participants