Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Consistently check overflow options #2225

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Normative: Consistently check overflow options #2225

merged 1 commit into from
Jul 1, 2022

Commits on May 24, 2022

  1. Normative: Consistently check overflow options 

    In the fast paths for Temporal objects in ToTemporalDate and
ToTemporalDateTime, the overflow option should be validated (even though
it isn't used.) We do this for property bags and also for the case where
we call Temporal.PlainDate.from(plainDate) and
Temporal.PlainDateTime.from(plainDateTime), so it should be consistent.

The status quo wasn't the result of any decision, it was an oversight.

Closes: #2220
    @ptomato
    ptomato committed May 24, 2022
    Configuration menu
    Copy the full SHA
    30c3f3f View commit details
    Browse the repository at this point in the history