Normative: Consistently check overflow options #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the fast paths for Temporal objects in ToTemporalDate and ToTemporalDateTime, the overflow option should be validated (even though it isn't used.) We do this for property bags and also for the case where we call Temporal.PlainDate.from(plainDate) and Temporal.PlainDateTime.from(plainDateTime), so it should be consistent. The status quo wasn't the result of any decision, it was an oversight. Closes: #2220
|
Draft until presented at TC39. |
Codecov Report
@@ Coverage Diff @@
## main #2225 +/- ##
==========================================
+ Coverage 82.10% 91.16% +9.06%
==========================================
Files 17 19 +2
Lines 10505 10528 +23
Branches 1468 1688 +220
==========================================
+ Hits 8625 9598 +973
+ Misses 1838 918 -920
+ Partials 42 12 -30
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ms2ger
approved these changes
May 25, 2022
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Jul 1, 2022
A normative change that reached consensus at the June 2022 TC39 meeting was this small change to throw on an invalid value for the overflow option in PlainDate.from() and PlainDateTime.from(), in the case of a fast-path conversion. See tc39/proposal-temporal#2225
|
This gained consensus at the June 2022 TC39 plenary meeting. Tests are in tc39/test262#3595 |
Ms2ger
pushed a commit
to tc39/test262
that referenced
this pull request
Jul 1, 2022
A normative change that reached consensus at the June 2022 TC39 meeting was this small change to throw on an invalid value for the overflow option in PlainDate.from() and PlainDateTime.from(), in the case of a fast-path conversion. See tc39/proposal-temporal#2225
pull bot
pushed a commit
to jamlee-t/v8
that referenced
this pull request
Aug 30, 2022
tc39/proposal-temporal#2225 Call ToTemporalOverflow in ToTemporalDate and ToTemporalDateTime Spec Text: https://tc39.es/proposal-temporal/#sec-temporal-totemporaldate https://tc39.es/proposal-temporal/#sec-temporal-totemporaldatetime Bug: v8:11544 Change-Id: I3d2846e2efc214ea5385be58cb49e319369b5900 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855705 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#82797}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the fast paths for Temporal objects in ToTemporalDate and
ToTemporalDateTime, the overflow option should be validated (even though
it isn't used.) We do this for property bags and also for the case where
we call Temporal.PlainDate.from(plainDate) and
Temporal.PlainDateTime.from(plainDateTime), so it should be consistent.
The status quo wasn't the result of any decision, it was an oversight.
Closes: #2220