Editorial: Introduce an SDO for checking legacy time zone names #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
force-pushed
the
2023-06-islegacyianatimezonename
branch
from
e2a97b3
to
ac193fb
Compare
Codecov Report
@@ Coverage Diff @@
## main #2606 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 20 20
Lines 11480 11480
Branches 2170 2170
=======================================
Hits 11039 11039
Misses 377 377
Partials 64 64 |
ptomato
approved these changes
Jun 13, 2023
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 18, 2023
…idermonkey-reviewers,mgaudet Implement the changes from - tc39/proposal-temporal#2600 - tc39/proposal-temporal#2604 - tc39/proposal-temporal#2606 Also moves `annotationValueComponent()` into the class, because it's both simpler and faster than the previous implementation. Depends on D182060 Differential Revision: https://phabricator.services.mozilla.com/D182061
ErichDonGubler
pushed a commit
to ErichDonGubler/firefox
that referenced
this pull request
Jul 19, 2023
…idermonkey-reviewers,mgaudet Implement the changes from - tc39/proposal-temporal#2600 - tc39/proposal-temporal#2604 - tc39/proposal-temporal#2606 Also moves `annotationValueComponent()` into the class, because it's both simpler and faster than the previous implementation. Depends on D182060 Differential Revision: https://phabricator.services.mozilla.com/D182061
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jul 21, 2023
…idermonkey-reviewers,mgaudet Implement the changes from - tc39/proposal-temporal#2600 - tc39/proposal-temporal#2604 - tc39/proposal-temporal#2606 Also moves `annotationValueComponent()` into the class, because it's both simpler and faster than the previous implementation. Depends on D182060 Differential Revision: https://phabricator.services.mozilla.com/D182061 UltraBlame original commit: 2de7da340caaad8e668a54faa44ec24696453005
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jul 21, 2023
…idermonkey-reviewers,mgaudet Implement the changes from - tc39/proposal-temporal#2600 - tc39/proposal-temporal#2604 - tc39/proposal-temporal#2606 Also moves `annotationValueComponent()` into the class, because it's both simpler and faster than the previous implementation. Depends on D182060 Differential Revision: https://phabricator.services.mozilla.com/D182061 UltraBlame original commit: 2de7da340caaad8e668a54faa44ec24696453005
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jul 21, 2023
…idermonkey-reviewers,mgaudet Implement the changes from - tc39/proposal-temporal#2600 - tc39/proposal-temporal#2604 - tc39/proposal-temporal#2606 Also moves `annotationValueComponent()` into the class, because it's both simpler and faster than the previous implementation. Depends on D182060 Differential Revision: https://phabricator.services.mozilla.com/D182061 UltraBlame original commit: 2de7da340caaad8e668a54faa44ec24696453005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I finally found a way to clean up the complexity of |TimeZoneIANAName| needing to support ASCII-case-insensitive matches of legacy time zone names. This PR introduces an IsLegacyIANATimeZoneName syntax-directed operation that checks against both the static list and the Etc/GMT±<UnpaddedHour> pattern, and also provides an explanatory note.