Editorial: Another batch of minor editorial improvements #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally, the validStrings.mjs test would fail if there were multiple parts of a duration that added up to a time duration that was past the limit. Anticipate this case and generate another string if it happens. See, for example: https://github.com/tc39/proposal-temporal/actions/runs/8272287985/job/22633836036
…mbers ParseISODateTime was previously specified to reject invalid dates and times before rejecting invalid annotations, except for the special case of rejecting a PlainYearMonth or PlainMonthDay whose first calendar annotation is present and specifies anything other than "iso8601". Refactoring it to process annotations first, removing the special case, makes it more comprehensible and easier to implement. This change only affects the messages of errors thrown in response to invalid input, and is therefore editorial. Closes: #2655
In a few places we used as hoc Records with fields [[ReferenceISOYear]] and [[ReferenceISODay]]. Remove these in favour of ISO Date Records, since they represent an ISO date anyway.
Ms2ger
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2655
Closes: #2831
cc @anba